Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: missing cpy script in file libs/library/package.json #2715

Open
malek-benazzouz opened this issue Jan 21, 2025 · 2 comments · May be fixed by #2727
Open

[Bug]: missing cpy script in file libs/library/package.json #2715

malek-benazzouz opened this issue Jan 21, 2025 · 2 comments · May be fixed by #2727
Assignees
Labels
bug Something isn't working priority:high quick

Comments

@malek-benazzouz
Copy link

malek-benazzouz commented Jan 21, 2025

Package name

core

Package version

11.5.3

Reproduction steps

Create a project with o3r generator, then generate a library:

npm create @o3r project
cd project
ng g library lib

Current result

In the generated libs/library/package.json file, there are occurrences to a cpy script, for example:

"prepare:build:builders": "npm run cpy 'collection.json' dist && npm run cpy 'schematics/**/*.json' dist/schematics",

However, this cpy script is not generated, so running this command will fail with:

npm error Missing script: "cpy"

Expected result

If we want to generate scripts containing npm run cpy, then we should also generate the cpy script.

Additional comments

No response

@malek-benazzouz malek-benazzouz added bug Something isn't working triage labels Jan 21, 2025
@sdo-1A
Copy link
Contributor

sdo-1A commented Jan 22, 2025

Replace run with exec and we are missing a dependency on cpy-cli

@vscaiceanu-1a
Copy link
Member

Actually, the cpy-cli dev dep is already there. We just need to use exec instead of run.

@vscaiceanu-1a vscaiceanu-1a linked a pull request Jan 23, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:high quick
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants