Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASSERTs should be heavy or there should be HEAVY_ASSERTs #1200

Open
codygunton opened this issue Jan 17, 2025 · 2 comments
Open

ASSERTs should be heavy or there should be HEAVY_ASSERTs #1200

codygunton opened this issue Jan 17, 2025 · 2 comments

Comments

@codygunton
Copy link
Collaborator

Most of our asserts are very small, and it would be nice if they could just be in place in release mode. If it's not possible to accomplish this, then perhaps we should two ASSERT builds, where most of the current ASSERTs go into one of them and that build becomes our standard development build. @ludamad suggested this or something similar in the past

@codygunton codygunton changed the title ASSERTS should be heavy or there should be heavy ASSERTS ASSERTs should be heavy or there should be HEAVY_ASSERTs Jan 17, 2025
@ludamad
Copy link
Collaborator

ludamad commented Jan 17, 2025

Noir has released with asserts for a long time and recently out ci moved to use assert build throughout

@ludamad
Copy link
Collaborator

ludamad commented Jan 17, 2025

Now the concern is more that we should be clear we are comfortable with all asserts in prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants