-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Identity] Re-enable interactiveBrowserCredential test #28373
Comments
Some learnings as I was digging into this: MSAL 2.x and Azure SDKTests are failing with:
Looking at MSAL's repo I found this issue by Matt, which was fixed in 2.x Trying to upgrade to MSAL 2.x causes a different error when running integration tests:
This also prevents us from upgrading communication-identity's MSAL version to 2.x So what's going on here (at least as far as I can tell)?
What can we do?
Just to make things much easier to understand I isolated the incompatibility between MSAL 2.x and the esm package - you can see that in this minimal repro Might be I am missing something super obvious! |
…#28580) ### Packages impacted by this PR @azure/identity ### Issues associated with this PR Resolves #28373 ### Describe the problem that is addressed by this PR This PR addresses 3 things, all thanks to @jeremymeng's work on esm4mocha: 1. Re-enables IBC test that was skipped due to #28373 3. Removes sinon stubbing of uuid, replacing it with recorder replacer 4. Fixes min/max tests for identity Unfortunately we are not out of the woods regarding msal-node and esm. We would need to get everyone migrated over to this loader before we can upgrade msal-node repo-wide :( ### Provide a list of related PRs _(if any)_ #28556
Per learnings below, figure out a way to correctly import MSAL 2.x in integration tests in identity
The text was updated successfully, but these errors were encountered: