Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infiltrator should not be left in the code #489

Open
Sbozzolo opened this issue May 15, 2024 · 2 comments · Fixed by #541
Open

Infiltrator should not be left in the code #489

Sbozzolo opened this issue May 15, 2024 · 2 comments · Fixed by #541
Milestone
Maintenance and I...

Comments

@Sbozzolo
Copy link
Member

Sbozzolo commented May 15, 2024 •
edited
Loading

RRTMGP.jl/test/clear_sky_utils.jl

Line 96 in 73280d6

exfiltrate && Infiltrator.@exfiltrate

Infiltrator is convenient, but it is a debug/developlment tool. It should not be left in the commited repo.

It is used in a few places.
@Sbozzolo Sbozzolo added this to the Maintenance and Improvements milestone May 15, 2024
@Sbozzolo
Copy link
Member Author

@sriharshakandala, since you are refactoring this package, could you also fix this?

@sriharshakandala sriharshakandala linked a pull request Sep 20, 2024 that will close this issue
Remove Infiltrator from test suite. #541
Merged
1 task
@sriharshakandala
Copy link
Member

Add back PR #541

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Maintenance and Improvements
Development

Successfully merging a pull request may close this issue.

Remove Infiltrator from test suite. CliMA/RRTMGP.jl
2 participants
@Sbozzolo @sriharshakandala