Fix token icon not updating properly #1485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes DefiLlama#1450 Update the token icon URL handling and validation in `components/RPCList/index.js`. * **Add icon URL validation**: Add a function `isValidIconUrl` to check if the icon URL is valid before displaying it. * **Set icon URL**: Define the icon URL using `chain.chainSlug`. * **State management**: Add state `validIconUrl` to manage the validity of the icon URL. * **Effect hook**: Use `useEffect` to validate the icon URL and update the state accordingly. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/DefiLlama/chainlist/issues/1450?shareId=XXXX-XXXX-XXXX-XXXX).
|
@Setland34 is attempting to deploy a commit to the Defillama Team Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1450
Update the token icon URL handling and validation in
components/RPCList/index.js.isValidIconUrlto check if the icon URL is valid before displaying it.chain.chainSlug.validIconUrlto manage the validity of the icon URL.useEffectto validate the icon URL and update the state accordingly.For more details, open the Copilot Workspace session.