-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export track data like in the Jbrowse 1 #3094
Comments
Would really be interested in this feature in JB2 as it is an essential way of sharing data with non-computational scientists. |
thanks for adding interest in this @Averstic what is the main feature that you generally use this for? is it the GFF export of a region? |
Yes indeed, the GFF export of a region would be of interest. Along with the possibility to extract the reference sequence of the current view, this in order to quickly extract sequence and annotation for import in other tools. |
@cmdcolin |
@Averstic it could be somewhat challenging. there are two general approaches which are not necessarily mutually exclusive
|
Thank you for this insight. On option 1, it would still be necessary to recalculate some of the coordinates of the original source file, as those are genome wide coordinates, while it would be more useful to be able to extract 'local' coordinates. On option 2. what would be the reason this feature was not carried over between the two versions? And how likely is it that this feature would make it to any future release? |
what type of workflow would want this transformation? just a note that jbrowse 1 did not do transformations like this.
I think it is possible this could make it into a future release. it wasn't intentional to not carry it over, just a limitation of dev resources |
With regard to the work mentioned in #3439, this is the feedback from the WormBase user: Hi, Scott. Thank you so much for you and jbrowse2 developer to develop this prototype so quickly. I make some suggestions as follows:
|
Items 1 and 2 above are pretty easy, and item 4 could be differences in annotation release but might be something. Item three is a little more tricky; I assume the CDS features need to be stashed when iterating through the features and I don't really know how to do that in JB/React. I may take a crack at 1 and 2 though. |
that is all very good feedback. (3), the CDS join, is attempted in the save_track_data branch but not sure if he received the same see welcome to try out further work on that branch |
the wormbase user updated his comment to say that he was using the wrong track which is why he didn’t get the results he expected and now all is well; his only additional comment would be that it would be nice for the downloaded file name to include the location in the name to prevent name collisions. |
New update from the WormBase user where he found what looks like a bug. From https://community.alliancegenome.org/t/genbank-format-downloading-from-jbrowse1-2/6772/11: user:
Me:
User:
|
@cmdcolin I don't think changes to implement this ^^^ made it into the last PR (where the "method" lines are spaced over to the rest of the text); I took a look at the code diffs for that branch and didn't see the obvious place to make a change, so I'm going to have to ask you to do it too. |
To reproduce:
but it needs to look like:
|
potentially the issue highlighted above points to a need to re-urlencode things before writing out, to gff/genbank but may be useful for the upstream wormbase-pipeline to not have newlines |
So given that the problem I cited above is really with the GFF (and will hopefully be fixed with the next WB release), do you feel comfortable pushing this into main, or do you want to add the re-encoding first? I don't have a strong opinion since it shouldn't be a problem for "well behaved" gff. ETA: |
I think that I would like this PR to improve architecturally and code quality wise before merge to main. it is a good proof of concept but may help to evolve a little bit before merge. I can keep this branch updated with main so you can keep using it |
also, if possible, keep the discussion of the particular PR on the PR page |
Discussed in #2810
Originally posted by Marie-Lahaye March 15, 2022
Hi,
I was wondering if there was a way to export track data, like in the Jbrowse 1? I remember that we could export track data on the region that we were visualizing.
For example exporting genes in GFF3 format from a specific region:
Is there a similar feature with the Jbrowse 2?
Thanks for any answer you have for me !
Marie
The text was updated successfully, but these errors were encountered: