Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from aiohttp to asks #5

Open
mehaase opened this issue Jan 22, 2019 · 2 comments
Open

Migrate from aiohttp to asks #5

mehaase opened this issue Jan 22, 2019 · 2 comments
Labels
refactor Refactoring without changing functionality

Comments

@mehaase
Copy link
Contributor

mehaase commented Jan 22, 2019

aiohttp and aiosocks are the last asyncio libraries in the project, and both are used in the downloader. We could migrate aiohttp to asks, which is fully Trio native, but there is no Trio equivalent to aiosocks yet.

@mehaase mehaase added the enhancement New feature or request label Jan 29, 2019
@mehaase
Copy link
Contributor Author

mehaase commented Feb 6, 2019

Also while updating the downloader, I can refactor how the session is created. The session object is recreated for every download, but most of its contents are the same. I could either create a kwargs dict in the constructor, or maybe even instantiate the Session object itself.

@mehaase mehaase added refactor Refactoring without changing functionality and removed enhancement New feature or request labels Feb 28, 2019
@mehaase
Copy link
Contributor Author

mehaase commented Jun 2, 2020

This looks like a potential solution: https://github.com/Ostoic/trio-socks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring without changing functionality
Projects
None yet
Development

No branches or pull requests

1 participant