Use proper mapexpr include feature for rewriting included expressions
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Julia 1.5, `include` has an official feature to rewrite the parsed expressions - no need manually mess with textual includes and parsing. Using this feature rather than relying on Base internals is recommended as it makes the package more robust to future changes in this infrastructure. In particular, I'm planning to change the module-local `include` to allow extensions in JuliaLang/julia#55949. This package is currently doing that, though it could be changed not to. However, by just using the official feature for what this package wants to do, we just sidestep the question entirely. The old code is retained for pre-1.5 compat.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Julia 1.5,
includehas an official feature to rewrite the parsed expressions - no need manually mess with textual includes and parsing. Using this feature rather than relying on Base internals is recommended as it makes the package more robust to future changes in this infrastructure. In particular, I'm planning to change the module-localincludeto allow extensions in JuliaLang/julia#55949. This package is currently doing that, though it could be changed not to. However, by just using the official feature for what this package wants to do, we just sidestep the question entirely. The old code is retained for pre-1.5 compat.