You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From a Slack conversation with @vtjnash it seems that the current implementation of disable_sigint is buggy. I quote him here:
IIUC, defer_signal is inherited from the Task that switched to it, which is a terrible design and not one that we should keep, but is currently what it appears to implement
#49541 (comment) suggests that the intent was (or should be) that the defer_signal state should really be task-local.
Maybe making it properly task-local could count as a simple bug fix that then could also be backported to the LTS version?
I am trying to fix the Ctrl+C handling in the VS Code extension and I think I won't be able to make much progress unless this is fixed.
I know that there have been a lot of (wide ranging) discussions how SIGINT handling in general could be improved, but in my ideal world those would not hold up a simple bug fix here :)
The text was updated successfully, but these errors were encountered:
From a Slack conversation with @vtjnash it seems that the current implementation of
disable_sigint
is buggy. I quote him here:#49541 (comment) suggests that the intent was (or should be) that the
defer_signal
state should really be task-local.Maybe making it properly task-local could count as a simple bug fix that then could also be backported to the LTS version?
I am trying to fix the Ctrl+C handling in the VS Code extension and I think I won't be able to make much progress unless this is fixed.
I believe the buggy code is essentially this
julia/src/task.c
Lines 710 to 740 in 36472a7
I know that there have been a lot of (wide ranging) discussions how SIGINT handling in general could be improved, but in my ideal world those would not hold up a simple bug fix here :)
The text was updated successfully, but these errors were encountered: