Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of bayesian model estimation #29

Open
p-gw opened this issue Feb 3, 2023 · 3 comments
Open

Improve performance of bayesian model estimation #29

p-gw opened this issue Feb 3, 2023 · 3 comments
Assignees
Milestone

Comments

@p-gw
Copy link
Member

p-gw commented Feb 3, 2023

Before the first release we should try to make models as performant as possible.

@p-gw p-gw added this to the 0.1.0 milestone Feb 3, 2023
@p-gw p-gw self-assigned this Feb 3, 2023
@t-alfers
Copy link
Member

t-alfers commented Feb 3, 2023

Turing.setrdcache(true) and Turing.setadbackend(:reversediff) is not provided anymore. Any reasons? Without these calls the model estimation is extremely slow. At least we should provide information for the user to load Turing and call these two functions after loading RaschModels.jl.

@t-alfers
Copy link
Member

t-alfers commented Feb 3, 2023

At least for the RaschModel with ReverseDiff and caching enabled, it looks quite nice, actually.

@p-gw
Copy link
Member Author

p-gw commented Feb 3, 2023

Turing.setrdcache(true) and Turing.setadbackend(:reversediff) is not provided anymore. Any reasons?

No, probably just slipped through when I refactored fit... Of course this needs to be put back in.

At least for the RaschModel with ReverseDiff and caching enabled, it looks quite nice, actually.

Yes, the rasch model I think is pretty good already, but I have the feeling that the polytomous models can be improved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants