-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip create panel when no Web Components on page #61
Comments
There are a few cases around this that would need some looking into:
The TODO comment is deprecated as I feel that the panel should load, even if there are no items on the page as they might appear dynamically. I think some kind of an overhaul of the panel UI itself and therefore, code loading would be in place, and could be considered for the next major version of WCDT. |
Cool. I will keep absorbing the codes and see if I can have any feedbacks for you. Another note: I was testing WCDT using this tiny web components project of mine: https://guitar-metronome.netlify.app/, and some properties are not showing inside the panel, I will check this as well once I have a good grasp of the codes :) |
Could you report the props not showing up with a clear re-production in a separate issue? |
Sure thing, I will create a separate issue once I check and confirm that it's not caused by the codes of that web components project. |
Hi @Matsuuu,
Thank you for creating this amazing tool.
I have folked and cloned the repo, and as I was walking thru the codes to get a better understanding how it works under the hood. I see this this TODO comment you left.
https://github.com/Matsuuu/web-component-devtools/blob/main/lib/devtools-init.js#L2
If I may work on that?
My thoughts process:
MutationObserver
?Brandon
The text was updated successfully, but these errors were encountered: