Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Overrides throttle function in pages #71

Open
nigelsim opened this issue Apr 30, 2024 · 1 comment
Open

[BUG]: Overrides throttle function in pages #71

nigelsim opened this issue Apr 30, 2024 · 1 comment
Assignees

Comments

@nigelsim
Copy link

Describe the bug
When the extension is active, a web page that has a global throttle function will have this function overridden. See here.

To Reproduce
Steps to reproduce the behavior:

  1. Install the extension
  2. Start the repo in the link above
  3. Type quickly in the input box
  4. Press the button
  5. See that only some of the text has transferred through

You can put a breakpoint in the ~ nicegui.js:145 and try to step into the throttle function.

Expected behavior
Webpage code should be uneffected.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Linux
  • Browser Chromium
  • Version 123.0.6312.122

Additional context
Add any other context about the problem here.

@Matsuuu
Copy link
Owner

Matsuuu commented May 2, 2024

Welp this is the first time I've had the injected codes conflict with global codes.

I'll be sure to take this into account in the future rework that is in progress. Thank you for reporting this!

@Matsuuu Matsuuu self-assigned this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants