Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Promise in componentDidMount and tests #143

Open
MartinBruun opened this issue Mar 11, 2022 · 0 comments
Open

Remove Promise in componentDidMount and tests #143

MartinBruun opened this issue Mar 11, 2022 · 0 comments
Labels
refactoring keeping the code clean and maintainable, counter the law of entropy

Comments

@MartinBruun
Copy link
Collaborator

Remove the promise in componentDidMount in WholeApp, since it unnecessarily creates a 2 second waiting time when the app starts. It should rather activate the tooltips at the moment the component has mounted.

Also, if changed, it is important the tests will be changed to only use a waitFor, instead of a SetTimeout. To check if the solution works, simply remove the SetTimeout in the Tooltips.int.test.js, and when they are green, they should work as intended.

@MartinBruun MartinBruun added the refactoring keeping the code clean and maintainable, counter the law of entropy label Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring keeping the code clean and maintainable, counter the law of entropy
Projects
None yet
Development

No branches or pull requests

1 participant