Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Improvements in Route Schedule #169

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tarunsinghofficial
Copy link
Collaborator

@tarunsinghofficial tarunsinghofficial commented Jan 21, 2025

Fixes #164, #163

Screenshots:

Before
image
image

After
image
image

@coveralls
Copy link

coveralls commented Jan 21, 2025

Coverage Status

coverage: 5.542% (-0.008%) from 5.55%
when pulling 038dc1a on tarunsinghofficial:ui-improvements
into 35a7025 on OneBusAway:main.

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't repro #163, so I'm not sure which change you've made that was supposed to fix that. In general, you should strive to submit a fix for a single issue in a single PR. If that doesn't make sense because you're accumulating several tiny fixes, then each commit should fix a single issue.

Sticky header

I see a gap above the sticky header, which is a regression.

image

underlined minutes

The new display for minutes is confusing to me because good links on the web are always underlined and these are not links. I am open to the possibility of a new visual treatment, but this isn't going to be it.

Show all routes button appears to be broken at first

When I first land on the schedule page, all of the routes are expanded, which means that Show All Routes does nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route Schedules View - Responsive Design Issues and UX Improvements
3 participants