Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore B028 if skip_file_prefixes is used #497

Closed
kasium opened this issue Oct 31, 2024 · 4 comments · Fixed by #503
Closed

Ignore B028 if skip_file_prefixes is used #497

kasium opened this issue Oct 31, 2024 · 4 comments · Fixed by #503
Labels
enhancement help wanted terrible_maintainer

Comments

@kasium
Copy link
Contributor

kasium commented Oct 31, 2024

If a warnings.warn call contains no stacklevel but skip_file_prefixes is set, no issue should be raised, because if skip_file_prefixes is used, the author basically skips stack entries and also stacklevel has an implicit miniumum value of 2 automatically
@kasium
Copy link
Contributor Author

kasium commented Jan 10, 2025

@cooperlees what do you think about this? Are you open for a contribution here?

@JelleZijlstra
Copy link
Collaborator

I agree with you here, PR welcome.

@cooperlees
Copy link
Collaborator

+1 - Thanks, sorry I missed it.

@kasium
Copy link
Contributor Author

kasium commented Jan 13, 2025

Sure, I'll do that

kasium added a commit to kasium/flake8-bugbear that referenced this issue Jan 13, 2025
@kasium
Ignore B028 if skip_file_prefixes is used
3f402b3 
Closes PyCQA#497
@kasium kasium mentioned this issue Jan 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted terrible_maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore B028 if skip_file_prefixes is used kasium/flake8-bugbear
3 participants
@JelleZijlstra @cooperlees @kasium