Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a miche viewer to the auto-evo prediction #5760

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Add a miche viewer to the auto-evo prediction #5760

merged 4 commits into from
Jan 10, 2025

Conversation

dligr
Copy link
Member

@dligr dligr commented Dec 17, 2024 •
edited by hhyyrylainen
Loading

Brief Description of What This PR Does

Adds a miche viewer to the auto-evo prediction explanation panel.

Related Issues

Closes #5682

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@dligr dligr added the review label Dec 17, 2024
@dligr dligr requested review from a team December 17, 2024 17:21
@revolutionary-bot
Copy link

We are currently in feature freeze until the next release.
If your PR is not just a simple fix, then it may take until the release to get reviewed and merged.

hhyyrylainen
hhyyrylainen approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I somehow missed the commits after my last review so sorry for getting back to this so late. I've now checked the code and tested in game and from a quick look this seems to fully work.

@hhyyrylainen hhyyrylainen added this to the Release 0.8.1 milestone Jan 10, 2025
@hhyyrylainen hhyyrylainen merged commit 2e7f3af into master Jan 10, 2025
4 checks passed
@hhyyrylainen hhyyrylainen deleted the autoevo_prediction_miches branch January 10, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhyyrylainen hhyyrylainen hhyyrylainen approved these changes

Assignees
No one assigned
Labels
review
Projects
Thrive Planning
Status: Done
Milestone
Release 0.8.1
Development

Successfully merging this pull request may close these issues.

Add a miche view to the auto-evo prediction explanation popup
3 participants
@dligr @revolutionary-bot @hhyyrylainen