Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: OCV from EIS data #47

Open
2 of 3 tasks
fg-personal opened this issue Nov 14, 2024 · 1 comment
Open
2 of 3 tasks

ENH: OCV from EIS data #47

fg-personal opened this issue Nov 14, 2024 · 1 comment
Assignees

Comments

@fg-personal
Copy link

fg-personal commented Nov 14, 2024

Feature Type

  • Adding new functionality to pyvium

  • Changing existing functionality in pyvium

  • Removing existing functionality in pyvium

Problem Description

I wish I could use pyvium to grab both EIS data at different frequencies and the values of open circuit voltage measured before the experiment. Is it possible at all?

Feature Description

While setting up an EIS measurement you can select "Apply wrt OCP", a monitor time and a monitor interval. However, that information is lost if I just use Tools.get_idf_data and it can be crucial to have.

Alternative Solutions

(...)

Additional Context

No response

@Gnpd Gnpd self-assigned this Nov 15, 2024
@Gnpd
Copy link
Contributor

Gnpd commented Nov 15, 2024

Thank you for bringing this up! I understand that the get_idf_data function currently does not handle OCP data and only extracts the primary data from the IDF file.

To address this, I plan to modify the get_idf_data function to optionally retrieve OCP data. For example, it could include an optional parameter like get_idf_data(idf_path, ocp=True) (or equivalent). This enhancement should provide the additional functionality you’re looking for while maintaining the current behavior as the default.

I’m already working on this and expect to have it implemented within the next week. I’ll update this thread as soon as the changes are ready for you to test.

Thanks again for your feedback—it helps us improve the library for all users!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants