Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Seperate Settings Tab in GUI Client #30

Open
gabehxd opened this issue Dec 31, 2019 · 4 comments
Open

Create Seperate Settings Tab in GUI Client #30

gabehxd opened this issue Dec 31, 2019 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@gabehxd
Copy link
Member

gabehxd commented Dec 31, 2019

Code for configuration is mainly all in the main form and would require a bit of abstraction

@gabehxd gabehxd added the help wanted Extra attention is needed label Dec 31, 2019
@Azure-Agst
Copy link
Contributor

In order to make the config abstract, we could probably use C#'s Settings.Default as the main configuration method. This method saves our variables in the .config file that already ships with the app, essentially replacing the JSON format we currently use. If we were to do this, we'd need to also add code to support conversion from the legacy JSON file to the new .config format as well.

@ioistired
Copy link
Contributor

Is that human-readable and writable for a non-technical user?

@Azure-Agst
Copy link
Contributor

Azure-Agst commented Dec 31, 2019 via email

@Azure-Agst
Copy link
Contributor

Update:
Had some time on my hands so I decided to look into this. Figured we might as well stick with JSON and ended up moving the load and save functions to the Config class. You can see my progress on my f/settings branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants