session lock surface: animate

[NamorNiradnug]

Session lock surface is currently appears without animation. Would be nice if it'd be animated.

[ammen99]

If anyone is looking in doing this, we would need to have the lock surface not be a regular surface + node attached to the scenegraph, but also a view. The existing code does most of the 'hard' work - input grabs, rendering, etc. The view implementation does not have to do much - see for a reference the colored rect views

wayfire/src/view/compositor-view.cpp

Lines 100 to 182 in 3c0da50

	/* Implementation of color_rect_view_t */
	wf::color_rect_view_t::color_rect_view_t() : wf::view_interface_t()
	{
	this->geometry = {0, 0, 1, 1};
	this->_color = {0, 0, 0, 1};
	this->border = 0;
	}
	std::shared_ptr<wf::color_rect_view_t> wf::color_rect_view_t::create(view_role_t role,
	wf::output_t *start_output, std::optional<wf::scene::layer> layer)
	{
	auto self = view_interface_t::create<wf::color_rect_view_t>();
	self->set_surface_root_node(std::make_shared<color_rect_node_t>(self));
	self->set_role(role);
	self->_is_mapped = true;
	self->get_root_node()->set_enabled(true);
	if (start_output)
	{
	self->set_output(start_output);
	if (layer)
	{
	auto parent = (layer == wf::scene::layer::WORKSPACE) ?
	start_output->wset()->get_node() : start_output->node_for_layer(*layer);
	wf::scene::readd_front(parent, self->get_root_node());
	}
	}
	wf::view_implementation::emit_view_map_signal(self, true);
	return self;
	}
	void wf::color_rect_view_t::close()
	{
	this->_is_mapped = false;
	emit_view_unmap();
	}
	void wf::color_rect_view_t::set_color(wf::color_t color)
	{
	this->_color = color;
	damage();
	}
	void wf::color_rect_view_t::set_border_color(wf::color_t border)
	{
	this->_border_color = border;
	damage();
	}
	void wf::color_rect_view_t::set_border(int width)
	{
	this->border = width;
	damage();
	}
	bool wf::color_rect_view_t::is_mapped() const
	{
	return _is_mapped;
	}
	void wf::color_rect_view_t::set_geometry(wf::geometry_t g)
	{
	damage();
	this->geometry = g;
	damage();
	}
	wf::geometry_t wf::color_rect_view_t::get_geometry()
	{
	return this->geometry;
	}
	wlr_surface*wf::color_rect_view_t::get_keyboard_focus_surface()
	{
	return nullptr;
	}
	bool wf::color_rect_view_t::is_focusable() const
	{
	return false;

[NamorNiradnug]

If anyone is looking in doing this, we would need to have the lock surface not be a regular surface + node attached to the scenegraph, but also a view. The existing code does most of the 'hard' work - input grabs, rendering, etc. The view implementation does not have to do much - see for a reference the colored rect views

wayfire/src/view/compositor-view.cpp

Lines 100 to 182 in 3c0da50

	/* Implementation of color_rect_view_t */
	wf::color_rect_view_t::color_rect_view_t() : wf::view_interface_t()
	{
	this->geometry = {0, 0, 1, 1};
	this->_color = {0, 0, 0, 1};
	this->border = 0;
	}
	std::shared_ptr<wf::color_rect_view_t> wf::color_rect_view_t::create(view_role_t role,
	wf::output_t *start_output, std::optional<wf::scene::layer> layer)
	{
	auto self = view_interface_t::create<wf::color_rect_view_t>();
	self->set_surface_root_node(std::make_shared<color_rect_node_t>(self));
	self->set_role(role);
	self->_is_mapped = true;
	self->get_root_node()->set_enabled(true);
	if (start_output)
	{
	self->set_output(start_output);
	if (layer)
	{
	auto parent = (layer == wf::scene::layer::WORKSPACE) ?
	start_output->wset()->get_node() : start_output->node_for_layer(*layer);
	wf::scene::readd_front(parent, self->get_root_node());
	}
	}
	wf::view_implementation::emit_view_map_signal(self, true);
	return self;
	}
	void wf::color_rect_view_t::close()
	{
	this->_is_mapped = false;
	emit_view_unmap();
	}
	void wf::color_rect_view_t::set_color(wf::color_t color)
	{
	this->_color = color;
	damage();
	}
	void wf::color_rect_view_t::set_border_color(wf::color_t border)
	{
	this->_border_color = border;
	damage();
	}
	void wf::color_rect_view_t::set_border(int width)
	{
	this->border = width;
	damage();
	}
	bool wf::color_rect_view_t::is_mapped() const
	{
	return _is_mapped;
	}
	void wf::color_rect_view_t::set_geometry(wf::geometry_t g)
	{
	damage();
	this->geometry = g;
	damage();
	}
	wf::geometry_t wf::color_rect_view_t::get_geometry()
	{
	return this->geometry;
	}
	wlr_surface*wf::color_rect_view_t::get_keyboard_focus_surface()
	{
	return nullptr;
	}
	bool wf::color_rect_view_t::is_focusable() const
	{
	return false;

Thanks, I was also thinking about that! I'm going to implement it in a few days.