shareDescription always being empty

[AyushBherwani1998]

Description

shareDescriptions in MpcKeyDetails is always empty. Also, it should be a Dictionary instead of an JSON encoded string.

[metalurgical]

Was the description set? If no, then this is correct.

No, we don't want dictionaries being created from json. It'll just end up back with the whole anycodable nonsense we spent a lot of time correcting.

[AyushBherwani1998]

For the first, share a description that at least has information on the type of the factor. This is very important for deleteFactor functionality. getAllFactorPub has just a list of factors pub key, and can't be determined what type of factor it's to delete.

You can check the web implementation, it returns Map of factor pubs with it's information like type and any additional metadata.

[metalurgical]

If the description has not been added using this function, then there is nothing to return:
https://github.com/tkey/tkey-mpc-swift/blob/74ea5301e316163b48e653ba107fd9edd4fe6bf8/Sources/ThresholdKey/ThresholdKey.swift#L797

If there are no descriptions set then there is nothing to return as finalKeyDetails.share_descriptions will be validly empty.

So were they set or not?

[AyushBherwani1998]

The factor key type description is always mandatory when creating the factor so that information should be available regardless of whether the additional metadata is available.

[metalurgical]

Ah, see what you mean. This will probably take a while to track down.