-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent error messages in test suite #1846
Comments
Interesting history. I submitted a PR to make the behavior consistent. #1847 |
I think some of the reasonable options for your test runner include:
I don't think you'll be happy trying to match the error text exactly -- even the spec interpreter test runner doesn't do that. But if you really want to, you could submit a #1076/#1089-style PR that goes and removes the indices everywhere they have leaked back in to the spec tests. My guess is that you'll be lonely trying to maintain that property; whatever forces motivated #1076/#1089 at the time don't seem to exist anymore, or somebody else would have complained earlier when an index was reintroduced. |
I understand your concerns, and after evaluation I think these changes are not necessary, so I will close it, thank you. |
I'm the author of pywasm. I'm trying to introduce more friendly error messages in my project, but I found some inconsistencies.
From spec/interpreter, the "uninitialized element" error should include the index value, but I found that the index value is both present and absent in spec/test.
spec/interpreter/exec/eval.ml
Line 101 in bd2aa85
spec/test/core/bulk.wast
Line 222 in bd2aa85
spec/test/core/bulk.wast
Line 227 in bd2aa85
The text was updated successfully, but these errors were encountered: