Implicit help command is outputted to stdout instead of stderr

[bbb651]

Currently, all of the following command output their respective help message to stdout:
niri help
niri --help
niri msg help
niri msg --help
niri msg action help
niri msg action --help

While the following output to stderr:
niri msg
niri msg action

This is the default clap behavior, e.g. cargo report does the same thing.
I think this is intended on clap's side to make turning subcommands optional forward compatible..? But I might be overthinking it, it could just be a bug.
Either way I don't think this behavior makes sense for niri, niri msg and niri msg action will never be standalone commands, and this makes it annoying to grep them.

Something that's more of a feature request but related: Should --json apply to help commands? I think it can useful to e.g. make a hotkey that pipes all actions into a launcher. For --help and implicit help it doesn't make sense, but for help explicitly I think it does:

$ niri msg -j action help
{"action":"quit","description":"Exit niri",...}

System Information

• niri version: niri 0.1.10-1 (unknown commit)
• Also tested with latest main (6e41220)

• Distro: Archlinux

• GPU: N/A

• CPU: N/A

[YaLTeR]

I think this behavior on clap's side is intended. niri msg is an incomplete command, so it errors and shows help, similar to how niri msg output dp-1 is an incomplete command that errors and shows help. Meanwhile, with help or --help you're explicitly requesting the help message.

Either way I don't think this behavior makes sense for niri, niri msg and niri msg action will never be standalone commands, and this makes it annoying to grep them.

I guess? What do you suggest? If there's some clap flag to automatically convert them to stdout, sure let's add it. If it requires manual code for each command, I'm not sure it's worth the trouble?

Something that's more of a feature request but related: Should --json apply to help commands? I think it can useful to e.g. make a hotkey that pipes all actions into a launcher. For --help and implicit help it doesn't make sense, but for help explicitly I think it does:

Idk about this, but again, if there's a way to do it fully automatically and easily then sure, otherwise not worth the trouble.

[bbb651]

I managed to make it work but it's pretty ugly, clap doesn't support custom subcommand parsers so it has to be part of the struct and handled after parsing, it's even worse with Action since it leaks there...

[YaLTeR]

Yeah that's not very pretty..