Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False Positive: Incorrect detection of amazon-sl license expression #4022

Open
xiaobokuai opened this issue Dec 16, 2024 · 2 comments · May be fixed by #4034
Open

False Positive: Incorrect detection of amazon-sl license expression #4022

xiaobokuai opened this issue Dec 16, 2024 · 2 comments · May be fixed by #4034
Labels
bug

Comments

@xiaobokuai
Copy link

Description

While using ScanCode Toolkit to scan the file rntpc_react-native-splash-screen/README.md, the tool incorrectly identified lines 8-9 as matching the amazon-sl license expression. Upon manual review, this detection appears to be a false positive.

How To Reproduce

Here is the project url https://gitee.com/openharmony-sig/rntpc_react-native-splash-screen.
Review the scan results. The following match is observed:

"reference_matches": [
            {
                "license_expression": "amazon-sl",
                "license_expression_spdx": "LicenseRef-.amazon.com.-AmznSL-1.0",
                "from_file": "rntpc_react-native-splash-screen/README.md",
                "start_line": 8,
                "end_line": 9,
                "matcher": "3-seq",
                "score": 80.0,
                "matched_length": 8,
                "match_coverage": 80.0,
                "rule_relevance": 100,
                "rule_identifier": "amazon-sl_8.RULE",
                "rule_url": "https://github.com/nexB/scancode-toolkit/tree/develop/src/licensedcode/data/rules/amazon-sl_8.RULE"
            }
        ]
@xiaobokuai xiaobokuai added the bug label Dec 16, 2024
@pombredanne
Copy link
Member

Thanks for the report!
This is a bug.

  1. https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/licensedcode/data/rules/amazon-sl_8.RULE should be using this text with a tagged required phrase
This library is licensed under the {{Amazon Software License}}.
  1. And we should have a few new rules for MIT added

Can I interest you in submitting a PR to fix this issue? 😇

@pombredanne
Copy link
Member

@xiaobokuai also I am always interested about ScanCode usages. I see on your profile links to https://github.com/oss-compass/ ... can you tell a bit about this?
Thank you!

@aayushkdev aayushkdev linked a pull request Dec 21, 2024 that will close this issue
Open
6 tasks
aayushkdev added a commit to aayushkdev/scancode-toolkit that referenced this issue Jan 14, 2025
@aayushkdev
Fixed False Positive detection for amazon-sl license by adding rules …
6280b26 
…for mit license and updating rules for amazon-sl license. issue aboutcode-org#4022

Signed-off-by: Aayush Kumar <[email protected]>
aayushkdev added a commit to aayushkdev/scancode-toolkit that referenced this issue Jan 14, 2025
@aayushkdev
Fixed False Positive detection for amazon-sl license by adding rules …
113d2e7 
…for mit license and updating rules for amazon-sl license. issue aboutcode-org#4022

Signed-off-by: Aayush Kumar <[email protected]>
aayushkdev added a commit to aayushkdev/scancode-toolkit that referenced this issue Jan 14, 2025
@aayushkdev
Fixed False Positive detection for amazon-sl license by adding rules…
bfc59d0 
… for mit license and updating rules for amazon-sl license. issue aboutcode-org#4022

Signed-off-by: Aayush Kumar <[email protected]>
aayushkdev added a commit to aayushkdev/scancode-toolkit that referenced this issue Jan 14, 2025
@aayushkdev
Fixed False Positive detection for amazon-sl license by adding rules…
d934954 
… for mit license and updating rules for amazon-sl license. issue aboutcode-org#4022

Signed-off-by: Aayush Kumar <[email protected]>
aayushkdev added a commit to aayushkdev/scancode-toolkit that referenced this issue Jan 14, 2025
@aayushkdev
Fixed False Positive detection for amazon-sl license by adding rules…
62133c1 
… for mit license and updating rules for amazon-sl license. issue aboutcode-org#4022

Signed-off-by: Aayush Kumar <[email protected]>
aayushkdev added a commit to aayushkdev/scancode-toolkit that referenced this issue Jan 14, 2025
@aayushkdev
Fixed False Positive detection for amazon-sl license by adding rules…
0ab5e12 
… for mit license and updating rules for amazon-sl license. issue aboutcode-org#4022

Signed-off-by: Aayush Kumar <[email protected]>
aayushkdev added a commit to aayushkdev/scancode-toolkit that referenced this issue Jan 17, 2025
@aayushkdev
Fixed False Positive detection for amazon-sl license by adding rules…
920b3e0 
… for mit license and updating rules for amazon-sl license. issue aboutcode-org#4022

 Signed-off-by: Aayush Kumar <[email protected]>
aayushkdev added a commit to aayushkdev/scancode-toolkit that referenced this issue Jan 17, 2025
@aayushkdev
Fixed False Positive detection for amazon-sl license by adding rules …
e24b636 
…for mit license and updating rules for amazon-sl license. issue aboutcode-org#4022

Signed-off-by: Aayush Kumar <[email protected]>
aayushkdev added a commit to aayushkdev/scancode-toolkit that referenced this issue Jan 17, 2025
@aayushkdev
Fixed False Positive detection for amazon-sl license by adding rules …
541312a 
…for mit license and updating rules for amazon-sl license. issue aboutcode-org#4022

Signed-off-by: Aayush Kumar <[email protected]>
aayushkdev added a commit to aayushkdev/scancode-toolkit that referenced this issue Jan 17, 2025
@aayushkdev
Fixed False Positive detection for amazon-sl license by adding rules …
0a26e33 
…for mit license and updating rules for amazon-sl license. issue aboutcode-org#4022

Signed-off-by: Aayush Kumar <[email protected]>
aayushkdev added a commit to aayushkdev/scancode-toolkit that referenced this issue Jan 17, 2025
@aayushkdev
Fixed False Positive detection for amazon-sl license by adding rules …
b4a7b61 
…for mit license and updating rules for amazon-sl license. issue aboutcode-org#4022

Signed-off-by: Aayush Kumar <[email protected]>
aayushkdev added a commit to aayushkdev/scancode-toolkit that referenced this issue Jan 17, 2025
@aayushkdev
Fixed False Positive detection for amazon-sl license by adding rules …
ae90f4b 
…for mit license and updating rules for amazon-sl license. issue aboutcode-org#4022

Signed-off-by: Aayush Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed false positive occuring in issue #4022 aayushkdev/scancode-toolkit
2 participants
@pombredanne @xiaobokuai