default shunt value and 3.2A max value

[siteswapjuggler]

• Arduino board: ANY

• Arduino IDE version (found in Arduino -> About Arduino menu): 2.2.0

• List the steps to reproduce the problem below (if possible attach a sketch or
  copy the sketch code in too):

  open ina228_test.ino example
  go to line 21 and 22

The values on those line doesn't match the Adafruit product page. https://www.adafruit.com/product/5832

First and imho the shunt value could be set by defaut to 0.015 to match the breakboard value

Secondly I didn't understand why you mention the 3.2A limit, the product page mention 10A or 2.75A depending on ADCRANGE which by the way seems not configurable in the actual version of the library.

I'd be happy to pull some suggestion but I was hoping to get in contact first.

Have a nice day

[geotsak]

I am also wondering why the 3.2A limit is mentioned, is there actually any such limitation?

[SylvainGarrigues]

The default appropriate value for the resistor as it is found on the Adafruit INA228 breakout board was implemented in commit b7af448 but later reverted in 55c98df.

@Dennis-van-Gils, as the author of those two commits, maybe you can share the reason it was reverted, as well as the reason for the comment about the 3.2A maximum supported current (the board can go up to 10A per product description)?

[Dennis-van-Gils]

I was asked by the Adafruit moderator of this repo, for reasons unknown to me, to revert back my commit that corrected the default values on the shunt resistor and max current. It is indeed clear in the spec sheet that the on-board shunt is 0.015 Ohm and the max current 10 A.

I believe that at initial commit of this repo the wrong values were copied over from another INA chip library and that the moderator is now afraid to "break" the library for those people that rely on these wrong default values. It's a moot point, because now everyone has to supply these arguments with the correct values in order to get proper operation of the chipset.

So yes, I'm still in favor to correct the default values, and I was not allowed to :) Didn't want to argue about it anymore, so I just went with it.