Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memento Camera Project Bundle not including library dependencies #112

Closed
djecken opened this issue Jan 10, 2024 · 6 comments · Fixed by #113
Closed

Memento Camera Project Bundle not including library dependencies #112

djecken opened this issue Jan 10, 2024 · 6 comments · Fixed by #113
Assignees

Comments

@djecken
Copy link

djecken commented Jan 10, 2024

When testing the download project bundle from the fancy camera (https://learn.adafruit.com/adafruit-memento-camera-board/fancy-camera ) page on the memento learn guide, the zip file does not include all of the necessary libraries, only the adafruit_pycamera library is added.

@jedgarpark
Copy link

@TheKitty I'm not git savvy enough to know how to troubleshoot this.

@jepler jepler transferred this issue from adafruit/Adafruit_Learning_System_Guides Jan 10, 2024
@jepler
Copy link
Member

jepler commented Jan 10, 2024

I suspect that's because the pycamera library fails to declare its dependencies. Transferred. I'll look into it tomorrow; I know how to troubleshoot & test.

@jepler
Copy link
Member

jepler commented Jan 10, 2024

@jepler
Copy link
Member

jepler commented Jan 10, 2024

bundle json has the following which also looks right:

{
  "dependencies": [],
  "external_dependencies": [
    "adafruit-circuitpython-aw9523",
    "adafruit-circuitpython-busdevice",
    "adafruit-circuitpython-debouncer",
    "adafruit-circuitpython-display-text",
    "adafruit-circuitpython-lis3dh",
    "adafruit-circuitpython-neopixel"
  ],
  "package": true,
  "path": "lib/adafruit_pycamera",
  "pypi_name": "adafruit-circuitpython-pycamera",
  "repo": "https://github.com/adafruit/adafruit_circuitpython_pycamera",
  "version": "0.0.7"
}

however this seems not to cause bundlefly or the screenshot maker to actually include these dependencies. Is it that these things should be in dependencies[] instead of external_dependencies[]? or something else.

@BlitzCityDIY
Copy link

hihi- i heard about this and did some testing and i don't think it's a pycamera issue- seems to be a bundle fly issue. i went to this guide: https://learn.adafruit.com/disconnected-co2-data-logger/coding-the-disconnected-co2-data-logger and when i downloaded the bundle it only had the rtc and scd40 libraries, no bus device or register. i went to the scd40 product guide and experienced the same behavior and the screenshot generated also only showed the device library, not the dependencies: https://learn.adafruit.com/adafruit-scd-40-and-scd-41/python-circuitpython#circuitpython-usage-3101400

@jepler jepler transferred this issue from adafruit/Adafruit_CircuitPython_PyCamera Jan 11, 2024
@jepler
Copy link
Member

jepler commented Jan 11, 2024

Based on @BlitzCityDIY's comment and my own research, it seems this is a problem in circuitpython-build-tools. Most likely I introduced it in #110.

The fallout is that dependencies became listed in `e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants