Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up the correct bash history file #209

Closed
fredmorcos opened this issue Jan 2, 2025 · 7 comments · Fixed by #210
Closed

Pick up the correct bash history file #209

fredmorcos opened this issue Jan 2, 2025 · 7 comments · Fixed by #210

Comments

@fredmorcos
Copy link
Contributor

I believe this line should reference $HISTFILE instead of the hard-coded $HOME/.bash_history; I have my bash history file under $XDG_STATE_HOME/bash/bash_history.

source_command = "tail -r $HOME/.bash_history"

@alexpasmantier
Copy link
Owner

Correct, would you mind making a PR to change that?

Otherwise I'll make the modification later on today 🙏🏻

@alexpasmantier
Copy link
Owner

Done, thanks for the feedback 🙏🏻

@alexpasmantier
Copy link
Owner

Does the bash history shell integration work out for you?
Curious having feedback related to #180

@fredmorcos
Copy link
Contributor Author

Does the bash history shell integration work out for you?

It doesn't work with this fix because - I guess - GNU tail does not have a -r flag. I replaced the call to tail with cat and now it works. However the history lines are ordered randomly. I haven't looked at why but perhaps it's the string fuzzy searching function when given an empty input at start? I do expect the history to be correctly ordered but in reverse.

@alexpasmantier
Copy link
Owner

See #215

@JulianGmp
Copy link

Hi,
I just ran into this with zsh, I saw that you fixed this in #210, but a bit later reversed it with #224.
Is there a particular reason for this?

@murlakatamenka
Copy link

Right, as of now (tv 0.9.2) it doesn't respect ZSH's $HISTFILE env var and thus shell history channel doesn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants