Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on start-up #233

Closed
loralb opened this issue Jan 6, 2025 · 5 comments · Fixed by #240
Closed

Crash on start-up #233

loralb opened this issue Jan 6, 2025 · 5 comments · Fixed by #240
Labels
bug Something isn't working

Comments

@loralb
Copy link

loralb commented Jan 6, 2025

Description
When invoking television with tv git-log in fish-shell repo, tag 3.7.1, the app crashes.

Example
git clone https://github.com/fish-shell/fish-shell.git && cd fish-shell
git checkout tags/3.7.1
tv git-log

Environment

  • OS: macOS 15.2
  • Project version: 0.8.8

Additional context
report-044ce60d-a53f-412a-bd4b-ba3f8c2b7151.txt

(file was a .toml, but github didn't like it)

@loralb loralb added the bug Something isn't working label Jan 6, 2025
@alexpasmantier
Copy link
Owner

Screenshot 2025-01-06 at 21 26 51

Wasn't able to reproduce the issue for some reason.

The bug report complains about the output of git log not being valid utf-8.

@loralb
Copy link
Author

loralb commented Jan 6, 2025

Mmm, then I have no idea why it happens to me. If I invoke git log the same way television does (i.e. git log --oneline --date=short --pretty="format:%h %s %an %cd"), I get a "normal" output, I guess:

Screenshot 2025-01-06 at 21 36 56

@xsy420
Copy link

xsy420 commented Jan 6, 2025

if .zsh_history is not utf-8, tv also crash in zsh-history channel. if I remove invalid utf8 characters tv works fine

@alexpasmantier
Copy link
Owner

This should fix the issue and just discard non valid utf8 characters from the input source.

@loralb
Copy link
Author

loralb commented Jan 7, 2025

Looks like it's working, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants