From 2880961e99c16995b179f4c45acc34b1d4ebbfa5 Mon Sep 17 00:00:00 2001 From: Pierre Millot Date: Mon, 15 Jul 2024 20:06:01 +0200 Subject: [PATCH 1/3] fix(specs): update shopify feature flags --- specs/ingestion/common/schemas/source.yml | 50 ++--------------------- 1 file changed, 4 insertions(+), 46 deletions(-) diff --git a/specs/ingestion/common/schemas/source.yml b/specs/ingestion/common/schemas/source.yml index 3da5cfc49d..3e745873cb 100644 --- a/specs/ingestion/common/schemas/source.yml +++ b/specs/ingestion/common/schemas/source.yml @@ -457,52 +457,10 @@ SourceUpdateShopify: type: object additionalProperties: false properties: - collectionIDIndexing: - type: boolean - default: false - description: | - Whether to index collection IDs. - - If your store has `has_collection_search_page` set to true, - collection IDs will be indexed even if `collectionIDIndexing` is false. - increaseProductCollectionLimit: - type: boolean - default: false - description: | - Whether to increase the number of indexed collections per product. - If true, Algolia indexes 200 collections per product. - If false, 100 collections per product are indexed. - defaultPriceRatioAsOne: - type: boolean - default: true - description: | - Whether to set the default price ratio to 1 if no sale price is present. - - The price ratio is determined by the ratio: `sale_price` / `regular_price`. - If no sale price is present, the price ratio would be 0. - If `defaultPriceRatioAsOne` is true, the price ratio is indexed as 1 instead. - excludeOOSVariantsForPriceAtTRS: - type: boolean - default: true - description: | - Whether to exclude out-of-stock variants when determining the `max_variant_price` and `min_variant_price` attributes. - includeVariantsInventory: - type: boolean - default: true - description: | - Whether to include an inventory with every variant for every product record. - hasCollectionSearchPage: - type: boolean - default: false - description: | - Whether to include collection IDs and handles in the product records. - productNamedTags: - type: boolean - default: false - description: | - Whether to convert tags on products to named tags. - - To learn more, see [Named tags](https://www.algolia.com/doc/integration/shopify/sending-and-managing-data/named-tags). + featureFlags: + type: object + description: Feature flags for the Shopify source. + additionalProperties: true SourceShopify: allOf: From 5ffe90a98adb8ad89f3cbd0d47f21b9f44e47656 Mon Sep 17 00:00:00 2001 From: Pierre Millot Date: Tue, 16 Jul 2024 12:33:47 +0200 Subject: [PATCH 2/3] trigger From 6d20fa47adfa3387872142bbb20b64193d8df892 Mon Sep 17 00:00:00 2001 From: Pierre Millot Date: Thu, 18 Jul 2024 00:58:12 +0200 Subject: [PATCH 3/3] verbose --- .github/workflows/check.yml | 2 +- scripts/cts/runCts.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 985fde72fa..eab6d428b4 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -431,7 +431,7 @@ jobs: type: minimal language: swift - - run: yarn cli cts run swift ${{ fromJSON(needs.setup.outputs.SWIFT_DATA).toRun }} + - run: yarn cli cts run swift ${{ fromJSON(needs.setup.outputs.SWIFT_DATA).toRun }} -v - name: Set output id: setoutput diff --git a/scripts/cts/runCts.ts b/scripts/cts/runCts.ts index 9f6737aa98..0e1567c058 100644 --- a/scripts/cts/runCts.ts +++ b/scripts/cts/runCts.ts @@ -114,7 +114,7 @@ async function runCtsOne( break; case 'swift': await run( - `swift test -Xswiftc -suppress-warnings -q --parallel ${filter((f) => `--filter ${f}.*`)}`, + `swift test -Xswiftc -suppress-warnings -v --parallel ${filter((f) => `--filter ${f}.*`)}`, { cwd, language,