-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser: keep selection visually stable #17747
Comments
i am working on this. |
hey @david-allison During long press, the grid scales up
This shift is expected because:
We could set the initial grid size in browser view to match the post-long-press grid size. This would eliminate the scaling transition and keep selected items aligned with touch points. |
What does this mean? Making the items larger when the checkbox doesn't appear? Not for now, we have a lot of information which we want to display, and we want the grid as vertically compact as possible. If you try 2.20.1, this functionality works as expected, and we should maintain the same functionality. |
okay could you clarify me what are the exact steps to reproduce the bug and what is expected , |
no it means to make sure upon selecting the row , the selected row doesn't shift from the position , we need to make the height of each cell in multiselect(or checkbox) view same as it was in normal recyclerview, i hope i make sense |
That breaks accessibility. Checkboxes have a minimum required height |
you are right , but then we have to do the opposite of it , making the normal view's cell height bigger. I am just discussing possible fixes. |
i tried with 2.20.1 and 2.21alpha5-debug both are working exacltly same |
@Scapesfear when there are not enough items to scroll, there's not much we can do, the items will expand to fill screen up to scroll. Try a deck with at least three screenfulls of cards and scroll to somewhere in the middle. Then test a long-press to switch into multi-select on an item in the middle of that second screen. What happens on 2.20.1 vs 2.21alpha5? |
Bonus, once you have more than 6 cards in your entire collection, you may have a chance at reproducing the crash-on-card edit using boundary condition scenarios as I mentioned. |
okay i will do it and tell the results |
i tested with 30cards and yes the 2.21alpha5 is not working as expected |
Before moving to a recyclerview, if long pressing an item, the selected item was still under the point that a user tapped after the grid had been resized
This is no longer the case
The text was updated successfully, but these errors were encountered: