Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version number (v23.2.0) may have been set wrong #246

Closed
5 of 7 tasks
BorePlusPlus opened this issue Jan 9, 2025 · 3 comments
Closed
5 of 7 tasks

Version number (v23.2.0) may have been set wrong #246

BorePlusPlus opened this issue Jan 9, 2025 · 3 comments

Comments

@BorePlusPlus
Copy link

BorePlusPlus commented Jan 9, 2025

Describe the bug

I'm not sure if this is a bug as such, but I was following your release notes and noticed that the version jumped from v0.23.2 to v23.2.0.

This may have been a mistake, so I thought I'd highlight it in case you want to unpublish within the 72-hour window. If you indeed intended to publish v23.2.0, then I am sorry for bothering you.

Reproduction

https://github.com/antfu-collective/ni/releases

System Info

Not applicable

Used Package Manager

n/a

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.

Contributions

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)
@BorePlusPlus BorePlusPlus changed the title Version number may have been set wrong. Version number (v23.2.0) may have been set wrong Jan 9, 2025
@byronogis
Copy link

This looks like the reason why it's done this way
Epoch Semantic Versioning

@sxzz
Copy link
Member

sxzz commented Jan 10, 2025

I believe this is by design. Read more in https://antfu.me/posts/epoch-semver

@sxzz sxzz closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2025
@BorePlusPlus
Copy link
Author

Alright—without the context, all I saw was a break in a predictable pattern, so I flagged it.

Thank you for highlighting the reasoning behind it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants