Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading variables printing; add failing tests for MockedProvider regarding missing/undefined variables #8285

Conversation

vith
Copy link

@vith vith commented May 26, 2021

Related: #6688

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@apollo-cla
Copy link

@vith: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

vith added 3 commits May 27, 2021 09:33
error will now look like:

```
Error: No more mocked responses for the query: query GetUser($username: String!) {
  user(username: $username) {
    id
    __typename
  }
}
, variables: {
  username: 'other_user',
  bar: 123,
  thisFieldIsPresentButUndefined: undefined
}
```
@vith vith force-pushed the missing-and-undefined-optional-fields-issues branch from c59c13a to 9049e65 Compare May 27, 2021 07:36
@vith
Copy link
Author

vith commented May 27, 2021

rebased on main again due to merge conflicts

@jerelmiller
Copy link
Member

Hey @vith 👋

Thanks for the contribution and your patience! We believe this was fixed with #11806 which was released in 3.11.0 so we are going to go ahead and close this. If you believe this is still necessary, please let us know and we'll take another look. Thanks!

@jerelmiller jerelmiller closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants