[Bug]: backup via cron scheduling fails when s3 upload is not configured

[wyattwalter]

Is there an existing issue for this?

• I have searched the existing issues

Description

When automated backups are configured by specifying a cron schedule in the environment variable (https://docs.appsmith.com/getting-started/setup/environment-variables#automatic-backups), the scheduled task assumes that uploading to S3 (https://docs.appsmith.com/getting-started/setup/instance-management/backup-and-restore/sync-backup-to-s3) should be done. But if the user, for any reason, decides to not setup S3 uploads, the backup fails and is removed from the filesystem.

This happens because the upload to S3 fails, that error is (rightfully) treated as a failure and the error is attempted to be sent to admins and the files are deleted: https://github.com/appsmithorg/appsmith/blob/release/app/client/packages/rts/src/ctl/backup/index.ts#L72-L77

The cleanup logic was added here: https://github.com/appsmithorg/appsmith/pull/37715/files

Steps To Reproduce

1. Deploy Appsmith business with environment variable APPSMITH_BACKUP_CRON_EXPRESSION="*/5 * * * *" (example to make it happen every 5 minutes)
2. Do not configure S3
3. Observe that backups are not being written to /appsmith-stacks/data/backup/ in the container

You'll also see errors in /appsmith-stacks/logs/appsmithctl/backup.log like:

2025-01-22T19:13:23.596Z [ INFO ] Finished taking a backup at /appsmith-stacks/data/backup/appsmith-backup-2025-01-22T19-13-18.240Z.tar.gz.enc
2025-01-22T19:15:00.308Z [ ERROR ] Error: Failed to upload archive: S3 credentials are not configured
    at uploadArchiveToS3Bucket (/opt/appsmith/src/ctl/aws.ts:81:11)
    at run (/opt/appsmith/src/ctl/backup/index.ts:52:17)
2025-01-22T19:20:00.296Z [ ERROR ] Error: Failed to upload archive: S3 credentials are not configured
    at uploadArchiveToS3Bucket (/opt/appsmith/src/ctl/aws.ts:81:11)
    at run (/opt/appsmith/src/ctl/backup/index.ts:52:17)
2025-01-22T19:25:00.305Z [ ERROR ] Error: Failed to upload archive: S3 credentials are not configured
    at uploadArchiveToS3Bucket (/opt/appsmith/src/ctl/aws.ts:81:11)
    at run (/opt/appsmith/src/ctl/backup/index.ts:52:17)
2025-01-22T19:30:00.309Z [ ERROR ] Error: Failed to upload archive: S3 credentials are not configured
    at uploadArchiveToS3Bucket (/opt/appsmith/src/ctl/aws.ts:81:11)
    at run (/opt/appsmith/src/ctl/backup/index.ts:52:17)

Public Sample App

No response

Environment

Production

Severity

Medium (Frustrating UX)

Issue video log

No response

Version

1.55