Kustomize 5.4.0+ regression: null values set in HelmChartInflationGenerator are ignored

[erwanval]

Checklist:

• I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• I've included steps to reproduce the bug.
• I've pasted the output of argocd version.

Describe the bug

Kustomize's HelmChartInflationGenerator ignore null values, which prevent removal of default values set in source chart's values.yaml.
This seems to be a regression from Kustomize 5.4.0 (see kustomize issue).
It worked properly with ArgoCD v2.11.0 (bundled with kustomize 5.2.1).

To Reproduce

# kustomization.yaml
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

generators:
  - helmchartinflation-crowdsec.yaml

# helmchartinflation-crowdsec.yaml
apiVersion: builtin
kind: HelmChartInflationGenerator
metadata:
  name: crowdsec
releaseName: crowdsec
namespace: crowdsec
name: crowdsec
repo: https://crowdsecurity.github.io/helm-charts
version: 0.13.0
includeCRDs: true
valuesInline:
  lapi:
    resources:
      requests:
        cpu: 10m
        memory: 100Mi
      limits:
        cpu: null # We want to remove the default from values.yaml
        memory: 100Mi
    persistentVolume:
      config:
        enabled: false
      data:
        enabled: false
  agent:
    resources:
      requests:
        cpu: 10m
        memory: 100Mi
      limits:
        cpu: null # We want to remove the default from values.yaml
        memory: 100Mi
    acquisition:
      - namespace: ingress-nginx
        podName: ingress-nginx-controller-*
        program: nginx

Expected behavior

apiVersion: apps/v1
kind: DaemonSet
metadata:
  name: crowdsec-agent
spec:
  [...]
  template:
    [...]
    spec:
      [...]
      containers:
        [...]
          resources:
            limits:
              memory: 100Mi
            requests:
              cpu: 10m
              memory: 100Mi

Actual Output

apiVersion: apps/v1
kind: DaemonSet
metadata:
  name: crowdsec-agent
spec:
  [...]
  template:
    [...]
    spec:
      [...]
      containers:
        [...]
          resources:
            limits:
              cpu: 500m # default from values.yaml still set
              memory: 100Mi
            requests:
              cpu: 10m
              memory: 100Mi

Screenshots

Version

argocd: v2.13.0+347f221
  BuildDate: 2024-11-04T12:09:06Z
  GitCommit: 347f221adba5599ef4d5f12ee572b2c17d01db4d
  GitTreeState: clean
  GoVersion: go1.23.1
  Compiler: gc
  Platform: linux/amd64

Logs

Paste any relevant application logs here.

[andrii-korotkov-verkada]

Using null as a way to remove the default value seems a bit hacky. From a design perspective, it shouldn't be in common values, but be in some common file for a subset of things. But overall, I think it may be justified to simplify overall configuration management.

[crenshaw-dev]

For now, the workaround is to load a working Kustomize version onto your repo server. If/when Kustomize patches the issue upstream, assuming it's on a patch release, we'll bump the version in 2.13.x.