Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: atuin 18.4 ignores workspaces = true #2536

Open
peterjanes opened this issue Jan 9, 2025 · 3 comments
Open

[Bug]: atuin 18.4 ignores workspaces = true #2536

peterjanes opened this issue Jan 9, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@peterjanes
Copy link

peterjanes commented Jan 9, 2025

What did you expect to happen?

  1. ~/.config/atuin/config.toml has workspaces = true
    1.1. I've never configured filter_mode or *_key_binding settings in ~/.config/atuin/config.toml.
  2. Current directory contains a .git subdirectory
  3. Pressing Ctrl+R starts in "WORKSPACE" mode, as in previous versions.

What happened?

Ctrl+R starts in "GLOBAL" mode. I have to press Ctrl+R three more times to get to "WORKSPACE" mode, toggling through "HOST" and "SESSION". This misbehaviour is consistent across Linux and Mac (I don't have Windows to test) and seems to have been introduced in 18.4.

Atuin doctor output

{
  "atuin": {
    "version": "18.4.0",
    "sync": {
      "cloud": true,
      "records": true,
      "auto_sync": true,
      "last_sync": "2025-01-09 18:04:29.278739 +00:00:00"
    },
    "sqlite_version": "3.46.0"
  },
  "shell": {
    "name": "bash",
    "default": "bash",
    "plugins": [
      "atuin",
      "bash-preexec"
    ],
    "preexec": "bash-preexec"
  },
  "system": {
    "os": "Darwin",
    "arch": "arm64",
    "version": "15.1",
    "disks": [
      {
        "name": "Macintosh HD",
        "filesystem": "apfs"
      },
      {
        "name": "Macintosh HD",
        "filesystem": "apfs"
      }
    ]
  }
}
{
  "atuin": {
    "version": "18.4.0",
    "sync": {
      "cloud": true,
      "records": true,
      "auto_sync": true,
      "last_sync": "2025-01-09 18:09:18.009209369 +00:00:00"
    },
    "sqlite_version": "3.46.0"
  },
  "shell": {
    "name": "bash",
    "default": "bash",
    "plugins": [
      "atuin",
      "bash-preexec"
    ],
    "preexec": "bash-preexec"
  },
  "system": {
    "os": "Fedora Linux",
    "arch": "x86_64",
    "version": "41",
    "disks": [
      {
        "name": "/dev/mapper/VolGroup00-LogVol00",
        "filesystem": "ext3"
      },
      {
        "name": "systemd-1",
        "filesystem": "autofs"
      },
      {
        "name": "/dev/sda1",
        "filesystem": "ext3"
      },
      {
        "name": "/dev/sdb1",
        "filesystem": "btrfs"
      },
      {
        "name": "/dev/sdc1",
        "filesystem": "fuseblk"
      }
    ]
  }
}


### Code of Conduct

- [X] I agree to follow this project's Code of Conduct
@peterjanes peterjanes added the bug Something isn't working label Jan 9, 2025
@MatthewNichols
Copy link

I seem to be having the same issue.

In case it is useful here is my Doctor output:

Atuin Doctor
Checking for diagnostics


Please include the output below with any bug reports or issues

{
  "atuin": {
    "version": "18.4.0",
    "sync": {
      "cloud": true,
      "records": true,
      "auto_sync": true,
      "last_sync": "2025-01-16 20:54:32.71286325 +00:00:00"
    },
    "sqlite_version": "3.46.0"
  },
  "shell": {
    "name": "zsh",
    "default": "zsh",
    "plugins": [
      "atuin"
    ],
    "preexec": "built-in"
  },
  "system": {
    "os": "Ubuntu",
    "arch": "x86_64",
    "version": "24.04",
    "disks": [
      {
        "name": "/dev/nvme0n1p2",
        "filesystem": "ext4"
      },
      {
        "name": "/dev/nvme0n1p2",
        "filesystem": "ext4"
      },
      {
        "name": "/dev/nvme0n1p1",
        "filesystem": "vfat"
      }
    ]
  }
}

@reedriley
Copy link

Possibly a regression from c5c5e9d?

@peterjanes
Copy link
Author

Adding filter_mode = "workspace" did restore the behaviour I was looking for, so that does look like the culprit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants