Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Command search appending instead of executing it. #2561

Open
1 task done
dougg0k opened this issue Jan 24, 2025 · 2 comments
Open
1 task done

[Bug]: Command search appending instead of executing it. #2561

dougg0k opened this issue Jan 24, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@dougg0k
Copy link

dougg0k commented Jan 24, 2025

What did you expect to happen?

To run the command or at least replace the current thing written.

What happened?

Let's say I type cd and then ctrl+r to search, I find a history, till here it's fine, it's not completely accurate history btw, but that's beside the point.

If I select a command from the list and press enter, the whole command is appended to what is written already.

A cd /path/ will turn into cdcd /path/


Edit:

Still, on that first ctrl+r mention, it expect you to type from nothing, where it could use what is typed already to automatically give the results.

This makes 2 issues or improvements?!

Atuin doctor output

{
  "atuin": {
    "version": "18.4.0",
    "sync": {
      "cloud": true,
      "records": true,
      "auto_sync": true,
      "last_sync": "1970-01-01 0:00:00.0 +00:00:00"
    },
    "sqlite_version": "3.46.0"
  },
  "shell": {
    "name": "nu",
    "default": "nu",
    "plugins": [
      "atuin"
    ],
    "preexec": "built-in"
  },
  "system": {
    "os": "CachyOS Linux",
    "arch": "x86_64",
    "version": "rolling",
    "disks": [
      ...manydisks
    ]
  }
}

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dougg0k dougg0k added the bug Something isn't working label Jan 24, 2025
@dougg0k
Copy link
Author

dougg0k commented Jan 25, 2025

I suppose it's suppose to work standalone. But even so, the bug are there.

If ctrl + o were to be the proper option, it conflicts with zellij, where zellij takes precedence over it. Not only ctrl + s also.

And probably more. https://github.com/zellij-org/zellij/blob/main/zellij-utils/assets/config/default.kdl

It should have a way to customize the keybinding to fix it, I havent found it.


Besides the bug, this is also a feature request, for keybinding customization.

It would be nice to have a easy way to do it.

e.g.,

[keybindings]
name-of-the-functionality = ctrl+i

@dougg0k
Copy link
Author

dougg0k commented Jan 25, 2025

1- Replace what is already typed with the history choice coming from ctrl+r.
2- Use the already typed when pressing ctrl+r to search based on that.
3- Add keybindings customization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant