[Enchantement] - Improvements to SAI Comment (Auto-Generate)

[TheSCREWEDSoftware]

Probably we could implement something similiar to wowgaming.

Going to use Razormanes are examples.

https://wowgaming.altervista.org/aowow/?npc=3266 and https://wowgaming.altervista.org/aowow/?npc=3269

Example:

id	comment
0	Razormane Defender - On aggro - Casts Battle Stance (self, once, 100% of the time)
1	Razormane Defender - In Combat (after 35 seconds) - Casts Demoralising Shout (current target, every 10 seconds, 60%)
2	Razormane Defender - In Combat (after 11.5 seconds) - Casts Heroic Strike (current targert, every 4 seconds, 100%)

Explanation:
(0) instead of no repeat from wowgaming, no repeat = once). dont know if % should ahve "of the time" after.

(1 and 2) dont know where better to place thte 35 seconds (after starting combat) and convert seconds to minutes or hours or days depending on their value. 60 seconds should say 1 minute.

Currently (not at pc so no access to keira)

id	comment
0	Razormane Defender - On aggro - Casts Battle Stance (i think it says no repeat)
1	Razormane Defender - In Combat - Casts Demoralising Shout
2	Razormane Defender - In Combat - Casts Heroic Strike

Does it clutter the comment section of the unit? Yes and no, since is informative information. First example we can see straight away that razormane defender casts in combat will cast demoralsing shout at the victim every 10 seconds with a 60% chance of casting after 35 in combat

[TheSCREWEDSoftware]

@Helias if you're able to give me just a guidance where these comments are generated and their criteria i could try to make an example or make this chances myself.

[Helias]

Here is the no-repeat

Keira3/libs/shared/sai-editor/src/sai-comment-generator.service.ts

Line 982 in 790101c

actionLine += ' (No Repeat)';

The function to generate comments starts here https://github.com/azerothcore/Keira3/blob/master/libs/shared/sai-editor/src/sai-comment-generator.service.ts#L198 and it's a bit long, we should split it into multiple parts ideally

[TheSCREWEDSoftware]

Just doing a quick glance on the phone this is indeed enormous