Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the FuncUnit.com build #196

Open
chasenlehara opened this issue Apr 6, 2017 · 3 comments
Open

Improve the FuncUnit.com build #196

chasenlehara opened this issue Apr 6, 2017 · 3 comments

Comments

@chasenlehara
Copy link
Member

You can run make to build & deploy the FuncUnit site, but the way it works seems like a hack:

  • The site folder has its own Makefile and package.json, which seems odd
  • At least one file is force-added unnecessarily (that whole script could probably use some attention/verification)
  • Static resources are loaded from different folders, depending on which main section you’re on (i.e. the home page loads resources from site/static, while the Guides page loads from guides/static)

Home page:
screen shot 2017-04-06 at 4 23 58 pm

Guides page:
screen shot 2017-04-06 at 4 24 28 pm

@chasenlehara
Copy link
Member Author

make doesn’t work out of the box on Windows. In the 2017-05-12 contributors meeting we discussed converting it to a Node.js script and using ShellJS.

@chasenlehara
Copy link
Member Author

Building the site is not working for me on Node 8 and npm 5 (it spits out an error about not being able to find brace-expansion).

@chasenlehara chasenlehara added p1 and removed p2 labels Jun 30, 2017
@chasenlehara chasenlehara self-assigned this Jul 17, 2017
chasenlehara added a commit that referenced this issue Jul 19, 2017
@chasenlehara
Copy link
Member Author

chasenlehara commented Jul 20, 2017

Basically everything in the original issue description still needs to be done, but we’re part way to making things better with Replace the Makefile with a Node script.

I’m moving this issue to the backlog because the rest of the fixes are not as urgent.

Another note: with the above PR, I was able to deploy the site with Node 8.1.4 and npm 5.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants