Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instant::add and Instant::subtract possibly need to be updated #109

Closed
nekevss opened this issue Nov 3, 2024 · 1 comment
Closed

Instant::add and Instant::subtract possibly need to be updated #109

nekevss opened this issue Nov 3, 2024 · 1 comment
Labels
C-internal Internal library improvements E-easy Easy issue to fix - Good for newcomers

Comments

@nekevss
Copy link
Member

nekevss commented Nov 3, 2024

The Instant built-in's add and subtract methods were implemented relatively early in the life of temporal_rs. Since then, there has been relatively sizeable refactors made to Duration that may have caused Instant's behavior to not align with the Temporal Proposal.

Ideally, we need to verify if the behavior is aligned with the specification. If it is, then more tests would probably be nice to ensure that behavior. If Instant align is not aligned with the current proposal, then the implementation needs to be updated.

@nekevss nekevss added the C-internal Internal library improvements label Nov 3, 2024
@nekevss nekevss added the E-easy Easy issue to fix - Good for newcomers label Dec 5, 2024
@nekevss
Copy link
Member Author

nekevss commented Jan 26, 2025

Marking this as complete. There are still three failing tests, but overall conformance has increased to 88% with 3 tests left that are currently fixed in temporal_rs main.

@nekevss nekevss closed this as completed Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-internal Internal library improvements E-easy Easy issue to fix - Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant