Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve development within Flatpak #2921

Open
3 of 4 tasks
TheEvilSkeleton opened this issue Jun 8, 2023 · 3 comments
Open
3 of 4 tasks

Improve development within Flatpak #2921

TheEvilSkeleton opened this issue Jun 8, 2023 · 3 comments
Labels
Feedback Feedback from the community.

Comments

@TheEvilSkeleton
Copy link
Member

TheEvilSkeleton commented Jun 8, 2023

There are a few difficulties with Bottles to test within Flatpak environments. I propose the followings:

  • Use .Devel suffix in the app ID (com.usebottles.bottles.Devel) to separate the containers.
  • Make utils/install.sh work well inside Flatpak. Currently, it's meant to be used outside of Flatpak, which makes it inconvenient. I changed a bit of the script:
#!/usr/bin/env bash
BUILD_DIR="build/"
if [ -d "$BUILD_DIR" ]; then
	rm -r build
fi
mkdir build
meson --prefix=$PWD/build build
ninja -j$(nproc) -C build
ninja install -C build

This makes it build and install in $(pwd)/build, and can be easily executed by running ./build/bin/bottles. We can run this script by entering in the Flatpak container: flatpak run -d --filesystem=$PWD --command=bash com.usebottles.bottles (or com.usebottles.bottles.Devel), and then running the script: ./utils/install.sh.

@orowith2os
Copy link
Contributor

Some initial work for the .Devel change has been pushed here, feel free to use it in the future: https://github.com/bottlesdevs/Bottles/tree/devel-manifest

TheEvilSkeleton added a commit to TheEvilSkeleton/Bottles that referenced this issue Dec 9, 2024
From this time onward, development flatpaks of Bottles will
be suffixed with `.Devel`. This allows us to test Bottles completely
separately from stable releases, making it easier to test without
affecting existing configurations.

Related: bottlesdevs#2921
TheEvilSkeleton added a commit to TheEvilSkeleton/Bottles that referenced this issue Dec 9, 2024
From this time onward, development flatpaks of Bottles will
be suffixed with `.Devel`. This allows us to test Bottles completely
separately from stable releases, making it easier to test without
affecting existing configurations.

Related: bottlesdevs#2921
mirkobrombin pushed a commit that referenced this issue Dec 10, 2024
From this time onward, development flatpaks of Bottles will
be suffixed with `.Devel`. This allows us to test Bottles completely
separately from stable releases, making it easier to test without
affecting existing configurations.

Related: #2921
@mirkobrombin
Copy link
Member

Is this still valid?

@orowith2os
Copy link
Contributor

The last checkbox in the original issue comment still needs to be wrapped up, but should be it afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feedback Feedback from the community.
Projects
None yet
Development

No branches or pull requests

3 participants