Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup outdated and not needed stuff #3611

Open
1 of 3 tasks
Qronikarz opened this issue Dec 18, 2024 · 5 comments · Fixed by #3672
Open
1 of 3 tasks

Cleanup outdated and not needed stuff #3611

Qronikarz opened this issue Dec 18, 2024 · 5 comments · Fixed by #3672
Labels
Feedback Feedback from the community.

Comments

@Qronikarz
Copy link
Contributor

Qronikarz commented Dec 18, 2024

Done:

  • 1. Website
  • 2. Bottles repository tags
  • 3. Forum links in READMEs (4 of 4)

On website there are few mentions that are no longer (well... for a long time now) true.
site

  1. Technically there's nothing wrong with "Snap & AppImage" card, but if Bottles is not planning to have these packages back, then it would be good to just delete them.
  2. "Other packages" should be deleted because it points to - https://docs.usebottles.com/getting-started/installation#other-packages documentation which presents Flathub, Flathub Beta and Manual builds. Maybe it's right, but then the description of this card should be changed since these are not non-official packages maintained by community.

On GitHub repository there are these tags:
tags
3. ppa - I don't even remember Bottles having Ubuntu PPA if that's what it means. So in this case this tag is not applicable for a very long time
4. appimage - No AppImage Bottles for many versions and the attempt was a fail so maybe only after Bottles Next.
5. archlinux - Is it really needed? There already is a linux tag. I don't think that tagging every distribution is needed, but if it refers to something else please explain.

@Qronikarz Qronikarz added the Feedback Feedback from the community. label Dec 18, 2024
@Qronikarz
Copy link
Contributor Author

Just another point to add to "cleanup":

Forum links in README.md in repositories.
Either remove them, or point to the new GitHub discussions:
https://github.com/bottlesdevs/dependencies
https://github.com/bottlesdevs/programs
https://github.com/bottlesdevs/Bottles
https://github.com/bottlesdevs/components

I mean. I could probably even do it myself, but it would list me as a contributor for Bottles and I don't know if it's fair for just 4 commits correcting a link. Plus I need to do a fork since it won't let me use web editor:
accessdenied

@orowith2os
Copy link
Contributor

I mean. I could probably even do it myself, but it would list me as a contributor for Bottles and I don't know if it's fair for just 4 commits correcting a link.

You're fine! Anything and everything is appreciated. Between Mirko working on Bottles Next, and Tesk working on Bottles Legacy, even small stuff like this is a big help. Go ahead and do it if you want to!

@Qronikarz
Copy link
Contributor Author

Qronikarz commented Jan 5, 2025

OK, I'll try the 3rd task then. Don't have permissions for 2nd one and 1st needs some discussion.

EDIT: Done. Tested all 4 in the GitHub preview to see if the links open correctly and yes, they do.

@TheEvilSkeleton TheEvilSkeleton pinned this issue Jan 6, 2025
TheEvilSkeleton pushed a commit to Qronikarz/Bottles that referenced this issue Jan 6, 2025
TheEvilSkeleton pushed a commit that referenced this issue Jan 6, 2025
@Qronikarz
Copy link
Contributor Author

Shouldn't this stay open for task 1 and 2?

@TheEvilSkeleton
Copy link
Member

Ugh, thanks. I didn't even realize the issue was closed by the commit -.-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feedback Feedback from the community.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants