Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File level lint warnings are not reported #215

Open
pkwarren opened this issue May 15, 2024 · 0 comments
Open

File level lint warnings are not reported #215

pkwarren opened this issue May 15, 2024 · 0 comments

Comments

@pkwarren
Copy link
Member

Currently, file-level lint warnings are not reported by the plugin. To fix, we should make the following changes:

  • BufIssue.toTextRange returns null if the start/end offsets are equal, which file-level lint warnings are (they're reported with start/end line and start/end column all set to 1). We should detect thse any report annotations as fileLevel() instead of range(...).
  • The IgnoreBufIssueQuickFix can't be used to ignore these lint failures for these types of errors. We should instead update the buf.yaml config file with https://buf.build/docs/configuration/v1/buf-yaml#ignore_only or come up with another appropriate fix.

This affects the following types of lint warnings:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant