Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert testReleaseHelp script to bash or python #26561

Open
bradcray opened this issue Jan 17, 2025 · 3 comments
Open

Convert testReleaseHelp script to bash or python #26561

bradcray opened this issue Jan 17, 2025 · 3 comments

Comments

@bradcray
Copy link
Member

With the merge of #26554, I believe that util/buildRelease/testReleaseHelp is now the only script in our code base that uses csh rather than bash or python (check my work). This issue is to capture the desire to convert it to bash or python to get us completely onto those two scripting technologies.

@jabraham17
Copy link
Member

I assume we also want to remove test scripts that use tcsh? I see a number of those, mostly in test/users/aroonsharma.

Also when grepping, I see our pbs-aprun launcher uses tcsh. Not sure what for, but presumably we would want to remove that.

@bradcray
Copy link
Member Author

Good point, I didn't think to look for those, and was grepping on /csh due to too many false positives with simply csh.

[aside: Interesting that those tcsh-based tests didn't fail in the recent linux32 run where the csh-based tests did… I hadn't realized tcsh has become more predictably available than csh, where I think it used to be the opposite.]

@bradcray
Copy link
Member Author

@jabraham17 : Looking more closely, those tcsh scripts don't seem to be used by our testing system, which may explain why they didn't cause failures. I also don't (personally) have a problem with tcsh scripts existing in a test directory if they're not scripts we invoke as part of testing, so I think those could stay as-is.

I had no memory about pbs-aprun using tcsh. Checking that case, that's related to the expect script that's used to interact with the queuing system to determine when the job has completed. I think it could/should be updated to use bash and opened #26566 to capture this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants