Added fetch_size constructor param #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skejserjensen
requested changes
Jan 23, 2025
skejserjensen
approved these changes
Jan 23, 2025
chrthomsen
reviewed
Jan 23, 2025
There was a problem hiding this comment.
It looks good. The name fetch_size is, however, with an underscore. Most (if not all) other parameters (incl. lookupatts, idfinder, defaultidvalue, rowexpander, initsql, cursorarg) are without underscores. So wouldn't it be better to not have an underscore (even though PEP8 allows it)?
|
I see your point (@chrthomsen), is it something you want me to fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76