Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make backend dev easier #189

Open
angrave opened this issue Feb 13, 2021 · 2 comments
Open

Make backend dev easier #189

angrave opened this issue Feb 13, 2021 · 2 comments
Assignees

Comments

@angrave
Copy link
Collaborator

angrave commented Feb 13, 2021

Move dockercompose files into webapi; so need for the Deployment project for developers
Run frontend as yarn if doing frontend dev or as a remote image that traffik uses; but these new docker-compose files will not know anything about the FrontEnd project and not attempt to build it by default.

Open ports so that debugging outside of docker is possible but only allow localhost to connect-
e.g. available externally on port 5443
localhost:5443:443

Drop appsettings.json; read .env instead if exists.
Set defaults so that if .env is missing or incomplete it still powers up

Future:
Should WebApi C# projects be collapsed into fewer projects e.g.collapse Common+Database ? The current structure is problematic with potential circular dependences.

@angrave angrave self-assigned this Feb 13, 2021
@ghost
Copy link

ghost commented Sep 1, 2021

@angrave I'm happy to work on this. I've got three questions:

  1. Right now there is no .env file in the WebAPI project, there is only a .env file in the Deployment project. Just to make sure I am understanding correctly, is this what you would like: to delete all uses of vs_appsettings.json in WebAPI and instead have a .env file in the WebAPI project in addition to the one in the Deployment project, but the WebAPI project only looks to the .env file in its own project (not the one in the Deployment project, which it assumes no knowledge of)?
  2. Could you explain more about opening the new port 5443 and who should/shouldn't have access to it? I think once I understand the purpose, it'll become more clear to me what is needed.
  3. I just want to confirm the following: when creating the new docker-compose files for the WebAPI project that no longer build the frontend project, I should leave the docker-compose files in the Deployment project as-is, right?

Is there anything else that you'd like me to look into to make backend dev easier?

@ghost ghost self-assigned this Sep 1, 2021
@angrave
Copy link
Collaborator Author

angrave commented Sep 1, 2021

1; Yes
2& 3 -
actually I worked on this issue already in an old branch, but was never merged to avoid discontinuity in production and deployment. Please leave this issue alone for now.

@ghost ghost removed their assignment Sep 1, 2021
@ghost ghost mentioned this issue Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant