Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commented code and TODO comments #107

Open
calebeby opened this issue Jul 9, 2018 · 0 comments
Open

Remove commented code and TODO comments #107

calebeby opened this issue Jul 9, 2018 · 0 comments
Assignees

Comments

@calebeby
Copy link
Member

calebeby commented Jul 9, 2018

There are some TODO comments that are more helpful, but they should probably be moved to GitHub Issues.

      // @TODO move these into fixtures?
 * @TODO is `extendedData` used by any callers?

Also there is commented code that should be removed

// Var config = require('./config');

And then there are these TODO comments 😭

import { deepObj, resourceKey, resourceId } from './object'; // TODO NO NO NO NO
    if (!fieldData.hasOwnProperty('contents')) {
      // TODO again
    }
import { deepCollection } from './object'; // TODO NOPE

All of these comments should be removed, and some of them should be moved into GitHub Issues.

@calebeby calebeby self-assigned this Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant