Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Assorted minor feature requests #8

Open
rmcgibbo opened this issue Dec 16, 2015 · 2 comments
Open

[FR] Assorted minor feature requests #8

rmcgibbo opened this issue Dec 16, 2015 · 2 comments

Comments

@rmcgibbo
Copy link

Thanks a bunch for making this! I'd like to get rid of maintaining my separate script that does mostly the same thing as this package. There are a two features that would be nice to have here to make that possible.

  1. Fail gracefully when a package fails to build
    • It's pretty common that a package might fail to build for a certain version of Python or something. Currently, this kills the whole job. IMO it would be nice to catch this and continue through the matrix even if a package fails to build, but then to set the exit status so that the calling script is notified about the failure. IIRC in omnia-md, we set the exit status to the number of failed builds, so if it's nonzero you still get a failure inside your CI system.
  2. Print summary of the packages that will be built.
    • Currently, the script prints out, for each possible build matrix item, whether or not it will be built here. That's useful but it's a little overwhelming if you have a lot of packages but are using --inspect-channels, so probably very few of them will be built. IMO it would be nice, at end maybe, to print out just the ones that will be built. Or maybe to use color highlighting for the ones that will be built?
@pelson
Copy link
Contributor

pelson commented Jan 5, 2016

Fail gracefully when a package fails to build

Yes, this is something I've thought about too, but not something I've looked into too much. I'm aware that conda-build does a number of sys.exit() calls, but that shouldn't be too hard to deal with. 👍 in being able to do this (as a toggle).

Print summary of the packages that will be built.

Definitely in favour of adding UI improvements. I'm keen to know which packages are not being built too (so that I know I'm not missing some valuable matrix items with my conditions), but there is no reason that the two lists have to be output at the same time. 👍

Are you interested in getting involved? It'd be great to get more 👀 on the codebase if so.

@pelson
Copy link
Contributor

pelson commented Jan 5, 2016

P.S. Hope you had a good 🎄 - I was pretty much offline for the duration, so sorry for not replying sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants