Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FY on the June invoices #175

Open
pbchase opened this issue Aug 21, 2023 · 1 comment
Open

Fix FY on the June invoices #175

pbchase opened this issue Aug 21, 2023 · 1 comment
Assignees

Comments

@pbchase
Copy link
Contributor

pbchase commented Aug 21, 2023

Philip said to Sandra, “For the June REDCap invoices--the ones you created on July 10, 2023, my dataset said the FY was "2023-2024", your data set said it was "2022-2023". Who is right?” Sandra is right given the way she is using that column.

The fix for this needs to be at https://github.com/ctsit/rcc.billing/blob/e79d9b578ca5828cfdc3b169e549da54a80bf1bd/etl/create_and_send_new_redcap_prod_per_project_line_items.R#L62C40-L62C40

Also, the name current_fiscal_year should be replaced.

@ChemiKyle
Copy link
Contributor

Perhaps this is pedantry, but in the spirit of the final statement, current_fiscal_year concept still exists at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants