hash user's ip for key generation

[ItsANameToo]

Could the user's IP address that's being used to generate a key be adjusted to make use of a hash instead? The line in question is https://github.com/danharrin/livewire-rate-limiting/blob/main/src/WithRateLimiting.php#L23

Having it as a hash of the IP instead would bring it in line with the way Laravel generates a key for throttling (see https://github.com/laravel/framework/blob/9.x/src/Illuminate/Routing/Middleware/ThrottleRequests.php#L172) and will also avoid using user-identifiable data when not necessary.

[danharrin]

Surely a hash will be calculated differently every time, hence the key will change and the rate limit wont work? Have you tested it?

[ItsANameToo]

when using sha1 it will not result in different hashes for the same input, unless you add a random salt to it. You can see it with tinker vs an online website:

> sha1('string')
= "ecb252044b5ea0f679ee78ec1a12904739e2904d"

http://www.sha1-online.com/:

[danharrin]

Fair enough. Can you PR then?

[ItsANameToo]

Sure, I'll get to that on monday!

[ItsANameToo]

#13