Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Use sqlglot.expression.SplitPart instead of local_expression.SplitPart in the custom dialects #1411

Open
1 task done
bishwajit-db opened this issue Jan 8, 2025 · 0 comments · May be fixed by #1415
Open
1 task done
Assignees
Labels
bug Something isn't working

Comments

@bishwajit-db
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Category of Bug / Issue

ReconcileError

Current Behavior

Currently, local_expression.SplitPart is being used to parse and generate SQL for the custom dialects (Snow and Databricks, etc.). We should use the built-in sqlglot.expression.SplitPart instead, as it is available now. Using local_expression.SplitPart is creating some issues in reconciliation with user-provided transformation for the target. Also, in Databricks custom dialect, we don't need to override splitpart_sql method.

Expected Behavior

Use sqlglot.expression.SplitPart

Steps To Reproduce

No response

Relevant log output or Exception details

No response

Sample Query

No response

Operating System

macOS

Version

latest via Databricks CLI

@bishwajit-db bishwajit-db added the bug Something isn't working label Jan 8, 2025
@vijaypavann-db vijaypavann-db linked a pull request Jan 9, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants