Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probably incorrect normalization? #21

Open
xwhjy opened this issue Apr 26, 2023 · 0 comments
Open

Probably incorrect normalization? #21

xwhjy opened this issue Apr 26, 2023 · 0 comments

Comments

@xwhjy
Copy link

xwhjy commented Apr 26, 2023

Hi,
Thanks for open-sourcing wav2clip!
I noticed that you normalize the data (line 189) within the ResNet forward function. I am wondering if you want to normalize each sample or each batch. Because I find if the batch size is larger than 1, the encoded embedding would be different from that when extracted with batch size as 1.

I change line 189 into line 190 and the obtained embedding would be the same no matter what the batch size is.

I might miss something. Please let me know if my fix is correct or not. Thanks a lot!
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant